333 generated avro class imports use model package instead of avro schema namespace #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways use Avro contained namespace. Test for file generation with external Avro schemas changed by adding new avro schema with namespace outside of the model package.
… file contains no namespace attribute as well as a test for said exception in AsyncApiGeneratorTest, testExceptionForTestIssueInvalidAvro(). Also Updated README to reflect behaviour.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jemacineiras
approved these changes
Apr 1, 2024
|
This pull request hasn't been labeled as |
jemacineiras
added
enhancement
|
Project version has not been updated in pom.xml. Please, update your version using https://semver.org specifications |
1 similar comment
|
Project version has not been updated in pom.xml. Please, update your version using https://semver.org specifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allow for MultiApi to reference correctly the package of autogenerated Avro classes by taking into account the namespace atribute contained in the file schemas instead of the configured MultiApi model package present in the project pom.xml.