send_multi: message improvements #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors in the feeding check_multi are hard to find if there is no output. And 'WARNING: 0 check_multi child checks submitted' sounds like 'something went wrong' ;). When no chunks could be read, send_multi now looks for a valid ASCIIZ messages in the STDIN input and prints them out. The only thing you have to do is to redirect STDERR to STDOUT in your command line: check_multi ... 2>&1 | send_multi ...
|
Hi Matthias, instead of warning, i would prefer Unknown. Should we change the return code too? Thanks, |
|
You're pretty right with UNKNOWN, go for it... -Matthias |
sni
added a commit
that referenced
this pull request
Nov 19, 2024
this leads to crashes sometimes:
#0 0x00007ffff6f56387 in raise () from /lib64/libc.so.6
#1 0x00007ffff6f57a78 in abort () from /lib64/libc.so.6
#2 0x00007ffff43bca95 in __gnu_cxx::__verbose_terminate_handler() () from /lib64/libstdc++.so.6
#3 0x00007ffff43baa06 in ?? () from /lib64/libstdc++.so.6
#4 0x00007ffff43baa33 in std::terminate() () from /lib64/libstdc++.so.6
#5 0x00007ffff43ba631 in __gxx_personality_v0 () from /lib64/libstdc++.so.6
#6 0x00007ffff41559f4 in ?? () from /lib64/libgcc_s.so.1
#7 0x00007ffff4155d44 in _Unwind_ForcedUnwind () from /lib64/libgcc_s.so.1
#8 0x00007ffff6ab0362 in __pthread_unwind () from /lib64/libpthread.so.0
#9 0x00007ffff6aa88e5 in sigcancel_handler () from /lib64/libpthread.so.0
#10 <signal handler called>
#11 0x00007ffff701020d in close () from /lib64/libc.so.6
#12 0x00007ffff55846ab in ?? () from /omd/sites/mon/lib/libgearman.so.8
#13 0x00007ffff558476e in ?? () from /omd/sites/mon/lib/libgearman.so.8
#14 0x00007ffff558d02d in ?? () from /omd/sites/mon/lib/libgearman.so.8
#15 0x00007ffff558d05e in ?? () from /omd/sites/mon/lib/libgearman.so.8
#16 0x00007ffff558fe78 in gearman_worker_free () from /omd/sites/mon/lib/libgearman.so.8
#17 0x00007ffff5e7e319 in gm_free_worker (worker=worker@entry=0x7ffff0386ee8) at common/gearman_utils.c:274
#18 0x00007ffff5e83f88 in result_worker (data=<optimized out>) at neb_module_naemon/result_thread.c:115
#19 0x00007ffff6aa9ea5 in start_thread () from /lib64/libpthread.so.0
#20 0x00007ffff701eb0d in clone () from /lib64/libc.so.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sven,
send_multi is too silent when the feeding check_multi has a problem, it only states:
WARNING: 0 check_multi child checks submitted
I now look for a ASCIIZ message in STDIN stream and provide this message instead,
if there were no successful child checks parsed.
The only thing to get this working is to add a '2>&1' to the check_multi cmdline.
Cheers,
-Matthias