EuiBreadcrumbs, EuiHeader and children, and EuiLink to TS (elastic#2391)

Migrate EuiBreadcrumbs, EuiHeader and children, and EuiLink to TypeScript.
snide · Oct 10, 2019 · 9d94ba8 · 9d94ba8
1 parent f54c9db
commit 9d94ba8
Show file tree

Hide file tree

Showing 52 changed files with 373 additions and 408 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 - Update Elastic-Charts to version 13.0.0 and updated the theme object accordingly ([#2381](https://github.com/elastic/eui/pull/2381))
 - Added new `EuiColorStops` component ([#2360](https://github.com/elastic/eui/pull/2360))
 - Added `currency` glyph to 'EuiIcon' ([#2398](https://github.com/elastic/eui/pull/2398))
+- Migrate `EuiBreadcrumbs`, `EuiHeader` etc, and `EuiLink` to TypeScript ([#2391](https://github.com/elastic/eui/pull/2391))
 
 **Bug fixes**
 

diff --git a/...bs/__snapshots__/breadcrumbs.test.js.snap → ...s/__snapshots__/breadcrumbs.test.tsx.snap b/...bs/__snapshots__/breadcrumbs.test.js.snap → ...s/__snapshots__/breadcrumbs.test.tsx.snap
@@ -11,18 +11,14 @@ exports[`EuiBreadcrumbs is rendered 1`] = `
     data-test-subj="breadcrumbsAnimals"
     href="#"
     rel="noreferrer"
-    title="[object Object]"
   >
-    <span>
-      Animals
-    </span>
+    Animals
   </a>
   <div
     class="euiBreadcrumbSeparator"
   />
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Reptiles"
     type="button"
   >
     Reptiles
@@ -34,7 +30,6 @@ exports[`EuiBreadcrumbs is rendered 1`] = `
     class="euiLink euiLink--subdued euiBreadcrumb euiBreadcrumb--truncate"
     href="#"
     rel="noreferrer"
-    title="Boa constrictor"
   >
     Boa constrictor
   </a>
@@ -44,7 +39,6 @@ exports[`EuiBreadcrumbs is rendered 1`] = `
   <span
     aria-current="page"
     class="euiBreadcrumb euiBreadcrumb--last"
-    title="Edit"
   >
     Edit
   </span>
@@ -58,7 +52,6 @@ exports[`EuiBreadcrumbs props max doesn't break when max exceeds the number of b
 >
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Animals"
     type="button"
   >
     Animals
@@ -68,7 +61,6 @@ exports[`EuiBreadcrumbs props max doesn't break when max exceeds the number of b
   />
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Reptiles"
     type="button"
   >
     Reptiles
@@ -78,7 +70,6 @@ exports[`EuiBreadcrumbs props max doesn't break when max exceeds the number of b
   />
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Boa constrictor"
     type="button"
   >
     Boa constrictor
@@ -89,7 +80,6 @@ exports[`EuiBreadcrumbs props max doesn't break when max exceeds the number of b
   <span
     aria-current="page"
     class="euiBreadcrumb euiBreadcrumb--last"
-    title="Edit"
   >
     Edit
   </span>
@@ -112,7 +102,6 @@ exports[`EuiBreadcrumbs props max renders 1 item 1`] = `
   <span
     aria-current="page"
     class="euiBreadcrumb euiBreadcrumb--last"
-    title="Edit"
   >
     Edit
   </span>
@@ -126,7 +115,6 @@ exports[`EuiBreadcrumbs props max renders 2 items 1`] = `
 >
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Animals"
     type="button"
   >
     Animals
@@ -145,7 +133,6 @@ exports[`EuiBreadcrumbs props max renders 2 items 1`] = `
   <span
     aria-current="page"
     class="euiBreadcrumb euiBreadcrumb--last"
-    title="Edit"
   >
     Edit
   </span>
@@ -159,7 +146,6 @@ exports[`EuiBreadcrumbs props max renders 3 items 1`] = `
 >
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Animals"
     type="button"
   >
     Animals
@@ -177,7 +163,6 @@ exports[`EuiBreadcrumbs props max renders 3 items 1`] = `
   />
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Boa constrictor"
     type="button"
   >
     Boa constrictor
@@ -188,7 +173,6 @@ exports[`EuiBreadcrumbs props max renders 3 items 1`] = `
   <span
     aria-current="page"
     class="euiBreadcrumb euiBreadcrumb--last"
-    title="Edit"
   >
     Edit
   </span>
@@ -202,7 +186,6 @@ exports[`EuiBreadcrumbs props render a popover is rendered 1`] = `
 >
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Animals"
     type="button"
   >
     Animals
@@ -239,7 +222,6 @@ exports[`EuiBreadcrumbs props render a popover is rendered 1`] = `
   <span
     aria-current="page"
     class="euiBreadcrumb euiBreadcrumb--last"
-    title="Edit"
   >
     Edit
   </span>
@@ -253,7 +235,6 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
 >
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Animals"
     type="button"
   >
     Animals
@@ -263,7 +244,6 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
   />
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Reptiles"
     type="button"
   >
     Reptiles
@@ -273,7 +253,6 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
   />
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Boa constrictor"
     type="button"
   >
     Boa constrictor
@@ -284,7 +263,6 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
   <span
     aria-current="page"
     class="euiBreadcrumb euiBreadcrumb--last"
-    title="Edit"
   >
     Edit
   </span>
@@ -298,7 +276,6 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
 >
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Animals"
     type="button"
   >
     Animals
@@ -308,7 +285,6 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
   />
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Reptiles"
     type="button"
   >
     Reptiles
@@ -318,7 +294,6 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
   />
   <button
     class="euiLink euiLink--subdued euiBreadcrumb"
-    title="Boa constrictor"
     type="button"
   >
     Boa constrictor
@@ -329,7 +304,6 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
   <span
     aria-current="page"
     class="euiBreadcrumb euiBreadcrumb--last"
-    title="Edit"
   >
     Edit
   </span>

diff --git a/...omponents/breadcrumbs/breadcrumbs.test.js → ...mponents/breadcrumbs/breadcrumbs.test.tsx b/...omponents/breadcrumbs/breadcrumbs.test.js → ...mponents/breadcrumbs/breadcrumbs.test.tsx
@@ -8,9 +8,9 @@ describe('EuiBreadcrumbs', () => {
   test('is rendered', () => {
     const breadcrumbs = [
       {
-        text: <span>Animals</span>,
+        text: 'Animals',
         href: '#',
-        onClick: e => {
+        onClick: (e: React.MouseEvent) => {
           e.preventDefault();
           console.log('You clicked Animals');
         },
@@ -19,7 +19,7 @@ describe('EuiBreadcrumbs', () => {
       },
       {
         text: 'Reptiles',
-        onClick: e => {
+        onClick: (e: React.MouseEvent) => {
           e.preventDefault();
           console.log('You clicked Reptiles');
         },