Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notification logic to ensure check in and out emails are delivered #13733

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

In this PR, email notifications are now sent before webhook notifications to ensure their deliverability in the cases where the webhook notification fails.

In addition, webhook that do fail are logged at the debug level as opposed to the error level that was used before.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@shortcut-integration
Copy link

@what-the-diff
Copy link

what-the-diff bot commented Oct 10, 2023

PR Summary

  • Improvement to Exception Handling
    The code now includes a new tool named 'GuzzleHttp\Exception\ClientException' in the CheckoutableListener.php file. This tool allows for better handling of specific errors that may occur during the system's operation.

  • Adjustment to Webhook Notification Check
    The verification for whether a webhook notification should be sent has been moved to occur after the notification has already been issued. This change has been implemented in both generic notifications and more specific onCheckedIn() notifications.

  • Logging of ClientException
    When issuing notifications (both checkout and checkin), if the ClientException tool detects an error, the system will now record a detailed log of this event. These logs will make it easier to recognize and address issues going forward. The same function has also been implemented for the onCheckedIn() system notifications.

@snipe
Copy link
Owner

snipe commented Oct 11, 2023

This looks great, thanks @marcusmoore!

@snipe snipe merged commit 138ec33 into snipe:develop Oct 11, 2023
6 checks passed
@marcusmoore marcusmoore deleted the bug/sc-23453 branch October 19, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants