-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added user agent, remote_ip, action_source to action_logs #14036
Conversation
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
This pull request has been linked to Shortcut Story #24355: Include IP and action_source in action_logs. |
PR Summary
Note: The inclusion of the same migration file is mentioned twice, and seems redundant, as the action is only executed once. Thus, in essence, a new migration file has been added to include the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, and is an awesome feature! You had mentioned (verbally) something about wanting to index these by default to make it easier to search and sort - is that something you're still interested in? Regardless, this looks good to go to me! Thank you!
Signed-off-by: snipe <snipe@snipe.net>
This PR logs the user agent, remote IP, and the action source of logged actions. This should help us better track down what's happening if data isn't being handled the way we expect, and can be useful for tracking down problematic updates.