Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create user permission to allow... managing user permissions #14049

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

snipe
Copy link
Owner

@snipe snipe commented Dec 18, 2023

Inception!

This is a stab at a PR that would limit users who can create/edit users from being able to assign individual permissions to those users. (As it stands, only superadmins can manage group memberships). More testing needed, but I think this is the right track.

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link

Copy link

what-the-diff bot commented Dec 18, 2023

PR Summary

  • Improved Security on User Permissions
    In the UsersController sections for both Api and Users, added ability to check if a user has permissions for modifying other users' permissions. This addition helps to ensure that only authorized individuals can make such changes, improving overall system security.

  • Streamlined Image Handling Process
    The logic on how we handle images in ImageUploadRequest is now more neat and concise with the removal of an "else" statement. This change makes the image handling process more efficient.

  • Enhanced Permission Management System
    A new permissions method was added to SnipePermissionsPolicy. Furthermore, a new permission identifier users.manage_permissions has been added to both the authentication service provider and the permissions config file. This implies more granularity and better management in controlling access to different system resources.

  • Permission-based View Modifications
    Made changes to the user interface views permissions-base.blade and edit.blade to only show certain sections like the 'permissions tab' and 'permissions section' to users that have the users.manage_permissions permission. This helps ensure that users only see options that they have the access rights to use, making the user interface more intuitive.

@snipe snipe marked this pull request as draft December 18, 2023 23:01
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe marked this pull request as ready for review February 28, 2024 12:16
@snipe snipe requested a review from uberbrady February 28, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant