Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade.php: More helpful output when we can't read .upgrade_requirements.json #15051

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

jerm
Copy link
Collaborator

@jerm jerm commented Jul 9, 2024

Handle json decode errors and display the raw output in such cases, to
better understand what's happening and help debugging

@jerm jerm requested a review from snipe as a code owner July 9, 2024 05:11
Copy link

what-the-diff bot commented Jul 9, 2024

PR Summary

  • Improved Certificate Handling on Windows
    The code has been enhanced to cater loading of intermediate certificates on Windows platform if the situation demands, making the application more flexible.

  • Modified Method for Upgrade Requirement Retrieval
    The strategy for pulling the upgrade requirements from GitHub has been amended which is expected to increase the efficiency and accuracy of the operation.

  • Enhanced Error Handling for JSON Decoding
    Introduces robust error handling procedures for situations of JSON decoding failures, thus increasing the reliability of the software.

  • Updated and Informative Error Message
    The error messages have now been upgraded to provide more detailed information about the issues and also suggest potential fixes. This enhances user experience by facilitating easier troubleshooting.

Handle json decode errors and display the raw output in such cases, to
better understand what's happening and help debugging
@jerm jerm force-pushed the jerm/add-upgrade-script-debugging branch from 555e9a3 to 25fabcc Compare July 9, 2024 05:12
@jerm jerm changed the title More helpful output when we can't read .upgrade_requirements.json upgrade.php: More helpful output when we can't read .upgrade_requirements.json Jul 9, 2024
@snipe snipe merged commit bfa42ff into develop Jul 10, 2024
9 checks passed
@snipe snipe deleted the jerm/add-upgrade-script-debugging branch July 10, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants