Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed A Translation Issue With Auth #15194

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fixed A Translation Issue With Auth #15194

merged 1 commit into from
Jul 31, 2024

Conversation

spencerrlongg
Copy link
Collaborator

Description

Removed extraneous validation arguments that were causing strange error bag messages.

Fixes SC-26247

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test Configuration:

  • PHP version: 8.1

@spencerrlongg spencerrlongg requested a review from snipe as a code owner July 30, 2024 23:25
@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jul 30, 2024

PR Summary

  • Updated Validation Approach in ResetPasswordController.php
    The validate() method has been reworked to only consider specific validation rules, thereby providing a more streamlined and efficient validation process. This change will achieve a cleaner codebase and improve application performance.

@spencerrlongg spencerrlongg changed the title Removed extraneous $request->validate() arguments Fixed A Translation Issue With Auth Jul 31, 2024
@snipe
Copy link
Owner

snipe commented Jul 31, 2024

Excellent, thank you!

@snipe snipe merged commit ca531e8 into snipe:develop Jul 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencerrlongg @snipe