Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #15371: docker-compose files updated. #15372

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

StarlessNights
Copy link
Contributor

Description

Fixes #15371

Some reworking to dev.docker-compose.yml. Mostly the issue was using a wrong .env file.
Besides that, this removes obsolete stuff, uses the official maridb healthcheck and bumps container versions.

I made the corresponding changes to docker-compose.yml too, and changed the restart policies to more reasonable unless-stopped.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

$ podman-compose -f dev.docker-compose.yml up
$ docker-compose -f dev.docker-compose.yml up

Both work.

Checklist:

@StarlessNights StarlessNights requested a review from snipe as a code owner August 22, 2024 13:22
Copy link

what-the-diff bot commented Aug 22, 2024

PR Summary

  • Link to MariaDB Documentation Added
    A link to the MariaDB documentation has been included within the .env.dev.docker file to provide more accessible information for resolving potential issues or queries related to MariaDB.

  • Updates to the dev.docker-compose.yml File
    This file has undergone several changes, including:

    • An update in the versioning, a switch to version 11.5.2 for MariaDB, and version 7.0.11 for Snipe-IT
    • Inclusion of a health check for MariaDB. This can potentially increase the stability of the system as it can ensure that MariaDB is functioning as expected.
    • A modification of the restart policy, which will impact how the containerized applications react following a crash or a system reboot.
  • Updates to the docker-compose.yml File
    This file has been updated with a new MariaDB version (11.5.2), a new restart policy, a healthcheck for MariaDB, and some added explanation comments. These updates aim to improve the overall functionality and resilience of the system.

  • Updated Version of Snipe-IT
    The version of Snipe-IT has been upgraded to v7.0.11 in the docker-compose.yml file. This could lead to better performance and access to new features or bug fixes in the application.

@snipe snipe merged commit ec365b0 into snipe:develop Aug 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants