Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #15416 - Added multiple selects for custom report #15418

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 29, 2024

This adds the ability to select multiple categories, status IDs, etc to the custom asset report. It also fixed a UI glitch that was causing the multi-select select2s to behave strangely, where they fell out of their container boxes:

Before

Screen.Recording.2024-08-29.at.6.34.53.PM.mov

After

Screen.Recording.2024-08-29.at.6.38.21.PM.mov

Refactor of #13482, Fixes #15416

snipe added 4 commits August 29, 2024 17:51
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Aug 29, 2024

PR Summary

  • Improved Database Queries in Asset.php
    The database query methods in the Asset.php file were modified with more efficient whereIn clauses replacing previous where clauses. This enhancement will potentially increase speed for retrieving assets.

  • Streamlined CSS Changes across Files
    Updates were made to several CSS classes in the app.css, overrides.css, all.css, and overrides.less files to improve the appearance and functionality of the website across different pages and features.

  • Updated Path in mix-manifest.json
    There were updates made to the path of CSS files in the mix-manifest.json file, ensuring that the latest CSS modifications are correctly referenced and applied throughout the application.

  • Localized Language Selection
    The localizations.php file was updated to enhance language selection process for a more intuitive and user-friendly experience.

  • Refined Form Macro Functionality
    Changes were made to the $select variable in macros.php, enhancing how the select input field works in forms throughout the application.

  • Enhanced Form Options
    Many .blade.php files in the resources/views/partials/forms/edit directory were updated with changes to conditionally include option tags. This would provide a more dynamic choice selection which adapts based on user interaction or data availability.

  • Updated Report Views
    The custom.blade.php file in the resources/views/reports directory was changed, providing an enhanced, more user-friendly way for users to select options when generating custom reports.

  • Modified Locale Field
    A change was made to the locale field in the edit.blade.php file in the resources/views/users directory, enhancing localization support for user profiles.

@snipe snipe merged commit 6fd24c7 into develop Aug 29, 2024
9 checks passed
@snipe snipe deleted the added_multiple_for_custom_report branch August 29, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant