-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Barcode Settings into Label Settings #15446
Conversation
PR Summary
|
@Godmartinz I know I was the one that brought this up via Shortcut, but are we sure this isn't going to break things for people? (I.e. is my logic even sound here? Would it be better to just combine the barcodes/labels sections instead of hiding the other settings?) |
refactor is complete 🙂 @snipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏾
@snipe I've added a migration to check the new barcode variables if empty and to replace them with the old values, then delete the old columns. |
Description
This removes the barcode settings from the admin settings menu and adds the functionality into the Labels settings.
Old Barcodes settings:
New labels settings with barcodes settings integrated:
(NOTE: the purge button works)
On the backend, the
postBarcodes
andgetBarcodes
have been integrated with thepostLabels
andgetLabels
respectively.Also rephrased "Display Square Codes" to "Display 2D Barcode" for uniformity.
Labels work 👍 :
Fixes #[sc-26651]
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: