Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Barcode Settings into Label Settings #15446

Merged
merged 18 commits into from
Dec 16, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Sep 3, 2024

Description

This removes the barcode settings from the admin settings menu and adds the functionality into the Labels settings.

Old Barcodes settings:
image

New labels settings with barcodes settings integrated:
image
(NOTE: the purge button works)

On the backend, the postBarcodes and getBarcodes have been integrated with the postLabels and getLabels respectively.

Also rephrased "Display Square Codes" to "Display 2D Barcode" for uniformity.
Labels work 👍 :
image

Fixes #[sc-26651]

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Sep 3, 2024

PR Summary

  • Introduction of Conditional Display in Settings
    This update adds a new functionality in the settings of our application. The system can now check certain conditions and according to the results, display different elements. Specifically, we're looking at the availability of a certain setting, named label2_enable. If this value is zero, a unique section of the interface will be shown to the user, enhancing the adaptability of the application.

@snipe
Copy link
Owner

snipe commented Sep 9, 2024

@Godmartinz I know I was the one that brought this up via Shortcut, but are we sure this isn't going to break things for people? (I.e. is my logic even sound here? Would it be better to just combine the barcodes/labels sections instead of hiding the other settings?)

@Godmartinz Godmartinz changed the title fixed barcode settings menu from appearing when new label engine is enabled Refactored Barcode Settings into Label Settings Sep 17, 2024
@Godmartinz
Copy link
Collaborator Author

refactor is complete 🙂 @snipe

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

resources/views/settings/labels.blade.php Outdated Show resolved Hide resolved
@Godmartinz
Copy link
Collaborator Author

@snipe I've added a migration to check the new barcode variables if empty and to replace them with the old values, then delete the old columns.

@snipe snipe merged commit edacc4e into snipe:develop Dec 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants