-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Ad-Hoc Notes on Assets #15525
base: develop
Are you sure you want to change the base?
Conversation
PR Summary
|
note: assets need to be rebuilt for note modal to close on save |
Taking a look at this now 👍🏾 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor notes but otherwise this is solid 💪🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏾
The ability to add a note to an asset uncoupled from an action (such as Checkin)
A pop-up window will open, and the note will save to the Asset History (as well as the activity log)
This replaces #14987
Type of change
How Has This Been Tested?
Ran snipe-it test suite through command line
Test Configuration:
Checklist: