Fixed Status Labels Error Message #15566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
snipe
requested changes
Oct 11, 2024
| @@ -95,7 +95,8 @@ public function store(Request $request) : JsonResponse | |||
| $request->except('deployable', 'pending', 'archived'); | |||
|
|
|||
| if (! $request->filled('type')) { | |||
| return response()->json(Helper::formatStandardApiResponse('error', null, ['type' => ['Status label type is required.']]), 500); | |||
|
|
|||
| return response()->json(Helper::formatStandardApiResponse('error', null, ['type' => ['Status label type is required.']])); | |||
There was a problem hiding this comment.
Why isn't normal validation kicking in here? Also this really shouldn't 500 at the API, since it's a validation error and we don't 500 on those.
|
Ping @Godmartinz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error message handler for status labels had an extra parameter in it. It was returning
Server Error: [object Object]. This fixes that.Before:
After:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: