-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added #15107: Customizable 2D Barcode Content for Asset Labels #15747
Added #15107: Customizable 2D Barcode Content for Asset Labels #15747
Conversation
Updated the translation function to use the correct path, ensuring that instead of displaying the translation path as plain text, the appropriate translation is now shown as intended.
PR Summary
|
This seems like the same (or similar) to #15721 no? |
Yes, but I have also included the Serial Number as part of the customizable content. Additionally, I am working on implementing logic that better separates links and data within the UI. |
I feel like maybe before opening a new PR, it might be more courteous to participate on the original PR that has been in progress for weeks to see if it could be a bit more collaborative between you and @Godmartinz who has been working on it. Now I'm supposed to choose between the two, which is not ideal. |
…Data:" labels, including translations
Thank you for the feedback! |
Looks like we have some failing tests here though. |
I’m not exactly sure why the tests failed, and I am unable to replicate the errors. Sending any type of emails works as expected, and they are being sent and received without any errors. I tested this on version 7.0.13 and now also on 7.1.14, both on Docker. |
Hrm, can you try merging/rebasing down from current develop? Maybe that will shed some more light. |
At least it's a different error now, so I think it wasn't an issue with my code. I'll revert the rebase after review to clean up this mess. |
8d144de
to
52e4414
Compare
Looks like everything is passing now after the rebase! Let me know if there’s anything else that needs attention. Would be great to get this merged soon. |
Looks good @snipe Thanks @NebelKreis 👍 |
@snipe Just wanted to check in and see if there’s any update on when this PR might be merged. Let me know if there’s anything else I can do! |
@NebelKreis looks like we have some conflicts that need to be resolved |
@snipe The conflicts have been resolved and everything should be good now. |
Description
This PR introduces a new feature that allows users to customize the content of the 2D barcodes generated for asset labels in Snipe-IT. Currently, the barcodes contain only the Snipe-IT link to the asset, which includes a sequentially generated ID or the asset tag. While this functionality serves its purpose, it limits the usability of the barcodes in various operational contexts.
To enhance this feature, the following changes were made:
Added options for users to include the following pieces of asset information in the 2D barcode:
The user interface for selecting the 2D barcode target now includes 2 more options, now allowing users to select whether they want to include the asset tag or the serial number in the 2D barcode.
Fixes Issue: #15107
By allowing for customizable barcode content, this change enhances the overall functionality of the asset labels. Users can now quickly access critical information such as the asset tag and serial number directly from the barcode, increasing efficiency in asset management processes.
Please delete options that are not relevant.
How Has This Been Tested?
Manual Testing: The new feature was manually tested to ensure that the customization options for the 2D barcode content are functioning correctly. This included verifying that the selected asset tag and serial number appear accurately in the generated barcodes.
Unit Tests: New unit tests have been added to confirm that the customization functionality works as intended. All existing tests were run to ensure that no regressions were introduced by this feature.
Test Configuration:
Checklist: