Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string to Password Reset Username Rules #15987

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

spencerrlongg
Copy link
Collaborator

This is just a quick addition to the sendResetLinkEmail() method's validation rules to prevent attempting to submit an array, this wasn't getting through before, but it will no longer 500 when someone attempts this. I couldn't trigger the 500 using dot notation, it just seems like that gets prevented because it's an unused parameter name, doesn't seem like it comes through as an array.

Copy link

what-the-diff bot commented Dec 18, 2024

PR Summary

  • Enhanced Validation Rules in sendResetLinkEmail Method
    The validation rules in the sendResetLinkEmail method have been updated to include checking if the 'username' field is a string. This enhancement aims to prevent potential issues that might occur when handling large data payloads.

@snipe snipe merged commit 0dce3b8 into snipe:develop Dec 18, 2024
9 checks passed
@snipe
Copy link
Owner

snipe commented Dec 18, 2024

Looks great, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants