Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable broken tests #5073

Merged
merged 11 commits into from
Feb 23, 2018
Merged

Disable broken tests #5073

merged 11 commits into from
Feb 23, 2018

Conversation

mnemonicly
Copy link
Contributor

Please don't merge yet, need to PR for travis feedback though. Will see what else needs to be nuked.

@mnemonicly mnemonicly requested a review from snipe as a code owner February 22, 2018 00:38
mnemonicly and others added 6 commits February 22, 2018 21:29
@mnemonicly
Work towards a functional travis. Step 1: Disable broken unit tests.
39966b2
@mnemonicly
Importer name/full name fixes.
542ed1b 
Fix a bug where "name" was used ambigously and mapping "item name" to
"name" would confuse the importer into thinking it should also be a user
name.  Now we default to "full name" for the users name, and "item name"
for the item name.  These are still both configurable through the custom
mapping.

Also update sample csvs and remove an outdated sample.
@mnemonicly
Fix functional tests
c824f79 
This updates the login information and model factories to work with
changes to source.
@mnemonicly
Max length of supplier notes is 191, not 255, as per default laravel …
7fa4997 
…string length. Might make sense to change this to a text field in the future to match other places.
@mnemonicly
Use sqlite/different db setup for unit tests.
83a0054
@mnemonicly
Fix assets api test.
25712dc
@mnemonicly
Copy link
Contributor Author

This should now be good. A lot of unit tests have been disabled, but all functional tests have been ported/fixed, and API tests have been ported or disabled for now.

I think when travis finishes the current run we might see green builds again?

@mnemonicly mnemonicly changed the title [WIP] Disable broken tests Disable broken tests Feb 23, 2018
@snipe
Copy link
Owner

snipe commented Feb 23, 2018

Looks like we're running out of memory?

@snipe
Copy link
Owner

snipe commented Feb 23, 2018

Found on Reddit, tho his was for a Laravel4 app:

From the docs:
Shared Memory
In functional testing unlike the traditional way, PHP application does not stop after it finished processing a request. As all requests run in one memory container they are not isolated. So if you see that your tests are mysteriously failing when they shouldn't - try to execute a single test. This will check if tests were isolated during run. Because it's really easy to spoil environment as all tests are run in shared memory. Keep your memory clean, avoid memory leaks and clean global and static variables.
If you want, you can just limit the memory usage of Codeception: http://codeception.com/docs/reference/Configuration . Though, I don't know how gracefully it will handle running out of memory, as I've never dealt with this issue personally.

@mnemonicly
Copy link
Contributor Author

The functional tests use a stupid amount of memory for some reason.. on the ones that succeed I see 700ish MB being used. Not sure why currently. I tried boosting the memory available to travis but it doesn't seem to be taking. Currently we reload the database fresh for each test, I need to look into whether or not thats actually necessary.

@snipe
Copy link
Owner

snipe commented Feb 23, 2018

https://www.reddit.com/r/PHP/comments/2vk8xi/codeception_out_of_memory/

@snipe snipe merged commit f7dbda4 into snipe:develop Feb 23, 2018
@mnemonicly mnemonicly deleted the disable-broken-tests branch July 17, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnemonicly @snipe