Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of stylistics changes #3

Merged

Conversation

jeremyletang
Copy link
Contributor

  • missing error checks
  • change fields naming to follow go convention
  • use time.Duration for the expires flag instead of string
  • close request body

@jeremyletang jeremyletang force-pushed the feature/stylistic-changes branch from 9aba694 to 79d823b Compare July 20, 2021 11:22
- missing error checks
- change fields naming to follow go convention
- use time.Duration for the expires flag instead of string
- close request body
@jeremyletang jeremyletang force-pushed the feature/stylistic-changes branch from 79d823b to 62401b6 Compare July 20, 2021 11:35
Copy link
Contributor

@rogerthebest rogerthebest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rogerthebest rogerthebest added the enhancement New feature or request label Jul 20, 2021
@rogerthebest rogerthebest added this to the v1.0.0 milestone Jul 20, 2021
@rogerthebest rogerthebest merged commit 2d3599e into sniptt-official:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants