Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double error reported when a REQUIRE_THROWS* fails for lack of exception being thrown #144

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fix double error reported when a REQUIRE_THROWS* fails for lack of exception being thrown #144

merged 2 commits into from
Nov 28, 2023

Conversation

cschreib
Copy link
Member

@cschreib cschreib commented Nov 28, 2023 •
edited
Loading

Fixes #143.
Closes #140.

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #144 (024a9c4) into main (f605e7e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          27       27           
  Lines        1597     1597           
=======================================
  Hits         1496     1496           
  Misses        101      101

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f605e7e...024a9c4. Read the comment docs.

@cschreib cschreib mentioned this pull request Nov 28, 2023
Closed
@cschreib cschreib merged commit 770286e into main Nov 28, 2023
43 checks passed
@cschreib cschreib deleted the throw branch November 28, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two different errors when REQUIRE_THROWS_AS doesn't throw Compilation error with MSVC 19.37
1 participant
@cschreib