Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve SendItems #132

Closed
Tracked by #122
plastikfan opened this issue Mar 26, 2024 · 1 comment · Fixed by #133
Closed
Tracked by #122

resolve SendItems #132

plastikfan opened this issue Mar 26, 2024 · 1 comment · Fixed by #133
Assignees
Labels
refactor Refactor code

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Mar 26, 2024

SendItems has been modified to accept a variadic collection of Items rather than T. This means that we now have to invoke in the foloowing way:

	rx.SendItems(context.Background(), ch, rx.CloseChannel,
		rx.Of(1),
		rx.Of(2),
		rx.Of(3),
	)

this is in contrast to to rxgo:

	rx.SendItems(context.Background(), ch, rx.CloseChannel,
		1, 2, 3,
	)

This issue is complicated by the fact we need to be able to represent a stream of values that may include an error. Using rxgo, we can effectively do this:

	rx.SendItems(context.Background(), ch, rx.CloseChannel,
		1, someErr, 3,
	)

but our modified version will not support this because error, can't be sent down a channel of T.

@plastikfan plastikfan mentioned this issue Mar 26, 2024
59 tasks
@plastikfan plastikfan self-assigned this Mar 26, 2024
@plastikfan plastikfan added feature New feature or request refactor Refactor code and removed feature New feature or request labels Mar 26, 2024
plastikfan added a commit that referenced this issue Mar 27, 2024
plastikfan added a commit that referenced this issue Mar 27, 2024
plastikfan added a commit that referenced this issue Mar 27, 2024
plastikfan added a commit that referenced this issue Mar 27, 2024
@plastikfan plastikfan linked a pull request Mar 27, 2024 that will close this issue
@plastikfan
Copy link
Contributor Author

Actually, the original description for this item is incorrect. We are not forced to use Of to send items, in fact doing so this way degrades the DX. We will and should not enforce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant