Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework config #112

Closed
Tracked by #40
plastikfan opened this issue Jan 12, 2024 · 0 comments · Fixed by #113
Closed
Tracked by #40

rework config #112

plastikfan opened this issue Jan 12, 2024 · 0 comments · Fixed by #113
Assignees
Labels
refactor Refactor code

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Jan 12, 2024

The current config is a bit of a problem, because it is causing duplicated code. The config interfaces are defined in proxy, but the implementation are defined in proxy. The problem starts with the mock data, that would need access to command, but doing so reveals an import cycle. So the resolutin would be to create a new cfg package that contains the implementation classes which could be reused by the mock config data.

@plastikfan plastikfan self-assigned this Jan 12, 2024
@plastikfan plastikfan added the refactor Refactor code label Jan 12, 2024
plastikfan added a commit that referenced this issue Jan 12, 2024
@plastikfan plastikfan linked a pull request Jan 12, 2024 that will close this issue
plastikfan added a commit that referenced this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant