Make db config common

.github/workflows/checks.yml

@@ -26,7 +26,7 @@ jobs:
         run: cp .env.dist .env
         working-directory: ./app/
 
-      # TODO: Uncomment after writing some tests
+      # TODO: Uncomment after writing some tests, since pytest exits with a non-zero code if there are no tests.
       # - name: Test
       #   run: docker compose run --rm app sh -c pytest
       #   working-directory: ./app/

app/.env.dist

@@ -0,0 +1 @@
+DATABASE_URL=postgres://postgres:change_me@db:5432/devdb

app/storeroom/settings/common.py

@@ -96,6 +96,15 @@
 USE_TZ = True
 
 
+# Parse database connection url strings
+# like psql://user:pass@127.0.0.1:8458/db
+DATABASES = {
+    # read os.environ['DATABASE_URL'] and raises
+    # ImproperlyConfigured exception if not found
+    "default": env.db(),
+}
+
+
 # Static files (CSS, JavaScript, Images)
 # https://docs.djangoproject.com/en/4.2/howto/static-files/
 

app/storeroom/settings/dev.py

@@ -5,14 +5,3 @@
 SECRET_KEY = "change_me"
 
 ALLOWED_HOSTS = ["*"]
-
-DATABASES = {
-    "default": {
-        "ENGINE": "django.db.backends.postgresql",
-        "NAME": "devdb",
-        "USER": "postgres",
-        "PASSWORD": "change_me",
-        "HOST": "db",
-        "PORT": "5432",
-    }
-}

app/storeroom/settings/prod.py

@@ -7,13 +7,3 @@
 SECRET_KEY = env("SECRET_KEY")
 
 ALLOWED_HOSTS = env("ALLOWED_HOSTS")
-
-# Parse database connection url strings
-# like psql://user:pass@127.0.0.1:8458/db
-DATABASES = {
-    # read os.environ['DATABASE_URL'] and raises
-    # ImproperlyConfigured exception if not found
-    #
-    # The db() method is an alias for db_url().
-    "default": env.db(),
-}