Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up workflows #119

Merged
merged 6 commits into from
Feb 12, 2023
Merged

Clean up workflows #119

merged 6 commits into from
Feb 12, 2023

Conversation

sondrelg
Copy link
Member

@sondrelg sondrelg commented Feb 11, 2023

Updates versions and purges a few tests. Also notably removes the old scripts needed to run the workflow for tags < 1.2.

It has been 18 months since v1.2 was released and the readme-examples have always used the @v1 tag. The workflow likely didn't have many users before this, so I doubt many if any will be affected by this.

@miigotu what do you think. It's not ideal, but it would be really nice to get rid of these. The old-script test is now also failing randomly, which is what made now seem like a good time :)

@sondrelg sondrelg force-pushed the fix-workflows branch 11 times, most recently from 1de12e4 to 38ed852 Compare February 11, 2023 23:16
@sondrelg sondrelg marked this pull request as ready for review February 11, 2023 23:17
@sondrelg sondrelg changed the title chore: Update workflow path Clean up workflows Feb 11, 2023
Since Poetry's lockfile formats aren't backwards compatible, we run into issues in our tests if we keep a v1.3.x version and vice versa for v1.2. This way each test can generate the format it needs.
It's failing for some reason, and I can't figure out how this tests anything novel, so let's remove it.
This might break a couple of workflows (hope not), but it's been 18 months since we changed the workflow to not rely on these, and the readme-examples have always used `v1`, so think the likelihood of things breaking for people is sufficiently low to finally go ahead with this.
@miigotu
Copy link
Collaborator

miigotu commented Feb 12, 2023

I generally only test for the current version in my projects. The test for previous versions exist on the git at the tagged commit, so there is no need to keep them around imo.

@sondrelg
Copy link
Member Author

IIRC we explicitly would fetch from the repo no the main branch in earlier versions, so it wasn't actually tied to the git version. That changed in v1.2 which we pushed in September 2021. Think I'll go ahead anyway, hoping no one will be affected 🤞 Anyone affected should be able to just change from v1.1.x to v.1.2.x or v1.3.x to fix it.

@sondrelg sondrelg merged commit 773ba01 into main Feb 12, 2023
@sondrelg sondrelg deleted the fix-workflows branch February 12, 2023 08:53
@gitonthescene
Copy link

This just bit me FWIW. I’m not complaining. It should be easy enough to fix. Rather, is there a preferred way to stay up-to-date? Should I just follow the project?

I’m not a super active user and mostly use this with buildbot pr’s.

@sondrelg
Copy link
Member Author

sondrelg commented Feb 17, 2023

Sorry @gitonthescene 🙇 We just made poor design decisions for the version < 1.2. Won't happen again. If you change the tag to v1 or v1.3.3 it should work going forward

@gitonthescene
Copy link

Really no worries at all. I changed it to v1 and that seemed to work. If there's something else I should be doing, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants