feat: Detect false negatives flag #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new flag to run language detection on all posts in the firehose. This allows the feed to include false negatives, at the cost of including some false positives as language detection on short posts is not perfect. We make it a flag so it is possible to run feed generator in old mode where it only looks at posts tagged with Norwegian. We still check for false positives in the old mode. Refactor the firehose module to be much more readable. Move the post processing and language detection logic out into a separate receiver method to make the event processor function much more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new flag to run language detection on all posts in the firehose. This allows the feed to include false negatives, at the cost of including some false positives as language detection on short posts is not perfect. We make it a flag so it is possible to run feed generator in old mode where it only looks at posts tagged with Norwegian. We still check for false positives in the old mode.
Refactor the firehose module to be much more readable. Move the post processing and language detection logic out into a separate receiver method to make the event processor function much more readable.