Filter the format option used in paths using a modified pathify #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -247,7 +247,7 @@ private function pathify($format) | |||
| if (is_array($format)) { | |||
| return md5(serialize($format)); | |||
| } else { | |||
| return $format; | |||
| return str_replace(array('<', '>'), array('L','G'), $format); | |||
There was a problem hiding this comment.
Be sure all special characters are handled, not only the one you use now.
Check https://github.com/snowcap/SnowcapImBundle/blob/master/docs/extra.rst to see example of other characters used.
|
Thank you to add Unit tests for your new behaviour. |
|
I'll try to add this ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter the format option used in cache paths using a modified
pathify()to avoid bug while creating cache directories (as seen in #16)