Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert go-ieproxy back to version 0.0.1 #689

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

sfc-gh-ext-simba-lb
Copy link
Contributor

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb commented Nov 14, 2022

Description

As part of #663, the go-ieproxy library was upgraded from 0.0.1 to 0.0.9.

#681 reported issues with version 0.0.9 when using the Go driver with terraform provider. We can't remove the library because it is an indirect dependency used by direct dependency github.com/Azure/azure-storage-blob-go.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb marked this pull request as ready for review November 14, 2022 19:03
@sfc-gh-igarish
Copy link
Collaborator

Was the upgrade related to a security issue? Does it mean we never able to upgrade?

@sfc-gh-ext-simba-lb
Copy link
Contributor Author

sfc-gh-ext-simba-lb commented Nov 14, 2022

Was the upgrade related to a security issue? Does it mean we never able to upgrade?

@sfc-gh-igarish No, we upgraded all dependencies in the previous release, this one did not have a security issue.

I found the issue is reported on the go-ieproxy repository: mattn/go-ieproxy#45
We won't be able to upgrade until this is resolved.

@sfc-gh-igarish
Copy link
Collaborator

Was the upgrade related to a security issue? Does it mean we never able to upgrade?

@sfc-gh-igarish No, we upgraded all dependencies in the previous release, this one did not have a security issue.

I found the issue is reported on the go-ieproxy repository: mattn/go-ieproxy#45 We won't be able to upgrade until this is resolved.

Ok. so how to track the actual issue of upgrade? Can you create another ticket to track it?

Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure you create an another ticket and put it here in comment.

@sfc-gh-ext-simba-lb
Copy link
Contributor Author

mattn/go-ieproxy#45

I created issue #690.

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb merged commit 8f21de7 into master Nov 17, 2022
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb deleted the revertIeProxyUpgrade branch November 17, 2022 00:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants