SNOW-974548 Upgrade AWS SDK #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-974548-aws-sdk
branch
from
63cdeda
to
d917d5a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 82.78% 82.80% +0.01%
==========================================
Files 50 50
Lines 9633 9643 +10
==========================================
+ Hits 7975 7985 +10
Misses 1658 1658 ☔ View full report in Codecov by Sentry. |
sfc-gh-dprzybysz
approved these changes
Nov 20, 2023
sfc-gh-dheyman-1
approved these changes
Nov 20, 2023
1 task
serprex
added a commit
to PeerDB-io/peerdb
that referenced
this pull request
Nov 20, 2023
Also: combine COPY/RUN commands in dockerfiles where applicable. Reduces size of images by reducing layers Hold back gosnowflake/aws-sdk-go, gosnowflake changed default PUT to ovewrite=false in 1.7.0 & aws-sdk-go has breaking changes in aws-sdk-go 1.48 https://docs.snowflake.com/en/release-notes/clients-drivers/golang-2023 snowflakedb/gosnowflake#971 aws/aws-sdk-go-v2#2162
sfc-gh-pfus
force-pushed
the
SNOW-974548-aws-sdk
branch
2 times, most recently
from
00717bd
to
3946751
Compare
sfc-gh-pfus
force-pushed
the
SNOW-974548-aws-sdk
branch
from
3946751
to
10c4c72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded AWS SDK library. Upgrade was needed as AWS client changed incompatibly.
Kudos for @kenshaw for suggesting the backward compatible solution!
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them