SNOW-710476 bulk update: batch execution for DML queries with arrayBindSupported=false #800
+420
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sfc-gh-ext-simba-hx <harry.xi@insightsoftware.com>
sfc-gh-ext-simba-hx
force-pushed
the
SNOW-710476-bulk-update-more-features
branch
from
fc732c6 to
f57e7a1
Compare
sfc-gh-ext-simba-hx
requested review from
sfc-gh-dprzybysz and
sfc-gh-jszczerbinski
|
@sfc-gh-jszczerbinski Too many warnings from code quality check seems due to missing baseline. |
tests/test_bind_params.c
Outdated
| @@ -414,13 +414,103 @@ void test_array_binding_supported_false(void** unused) { | |||
| snowflake_term(sf); | |||
| } | |||
|
|
|||
| void test_array_binding_supported_false_select(void** unused) { | |||
There was a problem hiding this comment.
let's rename the test - it's not select but insert with not supported array binding
There was a problem hiding this comment.
The insert case seems hit server issue though.
Server returns arrayBindSupported=true while it doesn't really support array binding for such query so the execution fails.
With local debugging I changed server response to arrayBindSupported=false and the test case worked.
Disable the test case for now until the server issue get fixed.
Please let me know if we need a ticket to track the progress.
tests/test_bind_params.c
Outdated
| snowflake_term(sf); | ||
| } | ||
|
|
||
| void test_array_binding_supported_false_insert(void** unused) { |
There was a problem hiding this comment.
this is select, not insert test - let's change naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teamwork issue 1038