Skip to content

Commit

Permalink
Stop running some nativeapp tests on v1 projects and ws command (#1699)
Browse files Browse the repository at this point in the history 
Since we now convert v1 definitions to v2 in-memory when running `snow app` command, we don't need to run all integration tests for v1 example projects anymore. Also, since the status of the `snow ws` command is uncertain (`snow app` and `snow ws` now call the same code under the hood), we're removing the `snow ws` parametrization from most tests. All in all, this reduces the Native App integration test suite from 300 unique tests to 128, which greatly speeds it up (from about 35 minutes to 19 minutes).

For safety, we're keeping full parametrization on a simple test for each feature, to make sure that the v1 to v2 conversion and `snow ws` command don't regress.
  • Loading branch information
@sfc-gh-fcampbell
sfc-gh-fcampbell authored Oct 15, 2024
1 parent 8aa1eef commit cc9cba5
Show file tree
Hide file tree
Showing 12 changed files with 95 additions and 574 deletions.
169 changes: 6 additions & 163 deletions tests_integration/nativeapp/__snapshots__/test_deploy.ambr
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,21 +44,6 @@

'''
# ---
# name: test_nativeapp_deploy_dot[app deploy-napp_init_v1]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Local changes to be deployed:
added: app/README.md -> README.md
added: app/manifest.yml -> manifest.yml
added: app/setup_script.sql -> setup_script.sql
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Validating Snowflake Native App setup script.
Deployed successfully. Application package and stage are up-to-date.

'''
# ---
# name: test_nativeapp_deploy_dot[app deploy-napp_init_v2]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Expand All @@ -74,34 +59,6 @@

'''
# ---
# name: test_nativeapp_deploy_dot[ws deploy --entity-id=pkg-napp_init_v2]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Local changes to be deployed:
added: app/README.md -> README.md
added: app/manifest.yml -> manifest.yml
added: app/setup_script.sql -> setup_script.sql
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Validating Snowflake Native App setup script.
Deployed successfully.

'''
# ---
# name: test_nativeapp_deploy_files[app deploy --no-validate-napp_init_v1]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Local changes to be deployed:
added: app/manifest.yml -> manifest.yml
added: app/setup_script.sql -> setup_script.sql
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Deployed successfully. Application package and stage are up-to-date.

'''
# ---
# name: test_nativeapp_deploy_files[app deploy --no-validate-napp_init_v2]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Expand All @@ -115,34 +72,6 @@

'''
# ---
# name: test_nativeapp_deploy_files[ws deploy --entity-id=pkg --no-validate-napp_init_v2]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Local changes to be deployed:
added: app/manifest.yml -> manifest.yml
added: app/setup_script.sql -> setup_script.sql
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Deployed successfully.

'''
# ---
# name: test_nativeapp_deploy_looks_for_prefix_matches[app deploy-napp_deploy_prefix_matches_v1]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Local changes to be deployed:
added: app/README.md -> README.md
added: app/manifest.yml -> manifest.yml
added: app/setup_script.sql -> setup_script.sql
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Validating Snowflake Native App setup script.
Deployed successfully. Application package and stage are up-to-date.

'''
# ---
# name: test_nativeapp_deploy_looks_for_prefix_matches[app deploy-napp_deploy_prefix_matches_v2]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Expand All @@ -158,33 +87,6 @@

'''
# ---
# name: test_nativeapp_deploy_looks_for_prefix_matches[ws deploy --entity-id=pkg-napp_deploy_prefix_matches_v2]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Local changes to be deployed:
added: app/README.md -> README.md
added: app/manifest.yml -> manifest.yml
added: app/setup_script.sql -> setup_script.sql
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Validating Snowflake Native App setup script.
Deployed successfully.

'''
# ---
# name: test_nativeapp_deploy_nested_directories[app deploy --no-validate-napp_init_v1]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Local changes to be deployed:
added: app/nested/dir/file.txt -> nested/dir/file.txt
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Deployed successfully. Application package and stage are up-to-date.

'''
# ---
# name: test_nativeapp_deploy_nested_directories[app deploy --no-validate-napp_init_v2]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Expand All @@ -197,33 +99,7 @@

'''
# ---
# name: test_nativeapp_deploy_nested_directories[ws deploy --entity-id=pkg --no-validate-napp_init_v2]
'''
Creating new application package myapp_pkg_@@USER@@ in account.
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Local changes to be deployed:
added: app/nested/dir/file.txt -> nested/dir/file.txt
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Deployed successfully.

'''
# ---
# name: test_nativeapp_deploy_prune[app deploy --no-prune-contains6-not_contains6-napp_init_v1]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
The following files exist only on the stage:
README.md

Use the --prune flag to delete them from the stage.
Your stage is up-to-date with your local deploy root.
Validating Snowflake Native App setup script.
Deployed successfully. Application package and stage are up-to-date.

'''
# ---
# name: test_nativeapp_deploy_prune[app deploy --no-prune-contains7-not_contains7-napp_init_v2]
# name: test_nativeapp_deploy_prune[app deploy --no-prune-contains4-not_contains4-napp_init_v2]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Expand All @@ -237,29 +113,7 @@

'''
# ---
# name: test_nativeapp_deploy_prune[app deploy --no-validate-contains3-not_contains3-napp_init_v1]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Deleted paths to be removed from your stage:
deleted: README.md
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Deployed successfully. Application package and stage are up-to-date.

'''
# ---
# name: test_nativeapp_deploy_prune[app deploy --no-validate-contains4-not_contains4-napp_init_v2]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Deleted paths to be removed from your stage:
deleted: README.md
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Deployed successfully. Application package and stage are up-to-date.

'''
# ---
# name: test_nativeapp_deploy_prune[app deploy --prune --no-validate-contains0-not_contains0-napp_init_v1]
# name: test_nativeapp_deploy_prune[app deploy --no-validate-contains2-not_contains2-napp_init_v2]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Expand All @@ -270,7 +124,7 @@

'''
# ---
# name: test_nativeapp_deploy_prune[app deploy --prune --no-validate-contains1-not_contains1-napp_init_v2]
# name: test_nativeapp_deploy_prune[app deploy --prune --no-validate-contains0-not_contains0-napp_init_v2]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Expand All @@ -281,7 +135,7 @@

'''
# ---
# name: test_nativeapp_deploy_prune[ws deploy --entity-id=pkg --no-prune-contains8-not_contains8-napp_init_v2]
# name: test_nativeapp_deploy_prune[ws deploy --entity-id=pkg --no-prune-contains5-not_contains5-napp_init_v2]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Expand All @@ -295,18 +149,7 @@

'''
# ---
# name: test_nativeapp_deploy_prune[ws deploy --entity-id=pkg --no-validate-contains0-not_contains0-napp_init_v2]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Deleted paths to be removed from your stage:
deleted: README.md
Updating the Snowflake stage from your local @@DEPLOY_ROOT@@ directory.
Deployed successfully.

'''
# ---
# name: test_nativeapp_deploy_prune[ws deploy --entity-id=pkg --no-validate-contains5-not_contains5-napp_init_v2]
# name: test_nativeapp_deploy_prune[ws deploy --entity-id=pkg --no-validate-contains3-not_contains3-napp_init_v2]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Expand All @@ -317,7 +160,7 @@

'''
# ---
# name: test_nativeapp_deploy_prune[ws deploy --entity-id=pkg --prune --no-validate-contains2-not_contains2-napp_init_v2]
# name: test_nativeapp_deploy_prune[ws deploy --entity-id=pkg --prune --no-validate-contains1-not_contains1-napp_init_v2]
'''
Checking if stage myapp_pkg_@@USER@@.app_src.stage exists, or creating a new one if none exists.
Performing a diff between the Snowflake stage and your local deploy_root ('@@DEPLOY_ROOT@@') directory.
Expand Down
Loading

0 comments on commit cc9cba5

Please sign in to comment.