Defer fetching role and warehouse until they're needed (#1631)

We have some commands, like `snow app bundle`/`snow ws bundle` that don't even need a connection, so let's defer connecting to Snowflake until it's actually needed by the particular action being run.

For now, all `snow ws` commands are still marked as requiring a connection, that will be fixed separately.

src/snowflake/cli/_plugins/workspace/action_context.py

@@ -1,6 +1,7 @@
 from dataclasses import dataclass
+from functools import cached_property
 from pathlib import Path
-from typing import Callable, Optional
+from typing import Callable
 
 from snowflake.cli.api.console.abc import AbstractConsole
 
@@ -13,6 +14,14 @@ class ActionContext:
 
  console: AbstractConsole
  project_root: Path
- default_role: str
- default_warehouse: Optional[str]
+ get_default_role: Callable[[], str]
+ get_default_warehouse: Callable[[], str | None]
  get_entity: Callable
+
+ @cached_property
+ def default_role(self) -> str:
+ return self.get_default_role()
+
+ @cached_property
+ def default_warehouse(self) -> str | None:
+ return self.get_default_warehouse()

src/snowflake/cli/_plugins/workspace/manager.py

@@ -31,13 +31,6 @@ def __init__(self, project_definition: ProjectDefinition, project_root: Path):
  self._entities_cache: Dict[str, Entity] = {}
  self._project_definition: DefinitionV20 = project_definition
  self._project_root = project_root
- self._default_role = default_role()
- if self._default_role is None:
- self._default_role = get_sql_executor().current_role()
- self.default_warehouse = None
- cli_context = get_cli_context()
- if cli_context.connection.warehouse:
- self.default_warehouse = to_identifier(cli_context.connection.warehouse)
 
  def get_entity(self, entity_id: str):
  """
@@ -62,8 +55,8 @@ def perform_action(self, entity_id: str, action: EntityActions, *args, **kwargs)
  action_ctx = ActionContext(
  console=cc,
  project_root=self.project_root(),
- default_role=self._default_role,
- default_warehouse=self.default_warehouse,
+ get_default_role=_get_default_role,
+ get_default_warehouse=_get_default_warehouse,
  get_entity=self.get_entity,
  )
  return entity.perform(action, action_ctx, *args, **kwargs)
@@ -72,3 +65,17 @@ def perform_action(self, entity_id: str, action: EntityActions, *args, **kwargs)
 
  def project_root(self) -> Path:
  return self._project_root
+
+
+def _get_default_role() -> str:
+ role = default_role()
+ if role is None:
+ role = get_sql_executor().current_role()
+ return role
+
+
+def _get_default_warehouse() -> str | None:
+ warehouse = get_cli_context().connection.warehouse
+ if warehouse:
+ warehouse = to_identifier(warehouse)
+ return warehouse

tests/workspace/test_application_package_entity.py

@@ -48,8 +48,8 @@ def _get_app_pkg_entity(project_directory):
  action_ctx = ActionContext(
  console=mock_console,
  project_root=project_root,
- default_role="app_role",
- default_warehouse="wh",
+ get_default_role=lambda: "app_role",
+ get_default_warehouse=lambda: "wh",
  get_entity=lambda *args: None,
  )
  return ApplicationPackageEntity(model), action_ctx, mock_console