Skip to content

Commit

Permalink
add Windows tests for connections.toml permissions (#1677)
Browse files Browse the repository at this point in the history
add Windows tests for connections.toml file
  • Loading branch information
sfc-gh-pczajka authored Oct 7, 2024
1 parent 3fcefb2 commit dda3ce5
Showing 1 changed file with 19 additions and 3 deletions.
22 changes: 19 additions & 3 deletions tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def test_too_wide_permissions_on_default_config_file_causes_error(

with pytest.raises(ConfigFileTooWidePermissionsError) as error:
config_init(None)
assert error.value.message.__contains__("config.toml")
assert "config.toml has too wide permissions" in error.value.message


@parametrize_icacls
Expand All @@ -300,7 +300,7 @@ def test_too_wide_permissions_on_default_config_file_causes_error_windows(

with pytest.raises(ConfigFileTooWidePermissionsError) as error:
config_init(None)
assert error.value.message.__contains__("config.toml")
assert "config.toml has too wide permissions" in error.value.message


@pytest.mark.parametrize(
Expand Down Expand Up @@ -364,7 +364,23 @@ def test_too_wide_permissions_on_default_connections_file_causes_error(

with pytest.raises(ConfigFileTooWidePermissionsError) as error:
config_init(None)
assert error.value.message.__contains__("connections.toml")
assert "connections.toml has too wide permissions" in error.value.message


@parametrize_icacls
@pytest.mark.skipif(condition=not IS_WINDOWS, reason="Windows permission system test")
def test_too_wide_permissions_on_default_connections_file_causes_error_windows(
snowflake_home: Path, permissions: str
):
config_path = snowflake_home / "config.toml"
config_path.touch()
connections_path = snowflake_home / "connections.toml"
connections_path.touch()
_windows_grant_permissions(permissions, connections_path)

with pytest.raises(ConfigFileTooWidePermissionsError) as error:
config_init(None)
assert "connections.toml has too wide permissions" in error.value.message


def test_no_error_when_init_from_non_default_config(
Expand Down

0 comments on commit dda3ce5

Please sign in to comment.