Disable snowflake.local.yml migration by default, add flag to enable it #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fcampbell
force-pushed
the
frank-migrate-local-flag
branch
from
1ecadcf
to
473fd50
Compare
| migrate_local_yml: bool = typer.Option( | ||
| False, | ||
| "-l", | ||
| "--migrate-local-overrides", |
There was a problem hiding this comment.
we might have to wordsmith this to explain that we'll include it in the conversion but not produce a separate file / a separate set of entities for it.
| @@ -35,10 +36,24 @@ def v1_to_v2( | |||
| accept_templates: bool = typer.Option( | |||
| False, "-t", "--accept-templates", help="Allows the migration of templates." | |||
| ), | |||
| migrate_local_yml: bool = typer.Option( | |||
| False, | |||
There was a problem hiding this comment.
As discussed offline, would prefer to make this abort the migration if a snowflake.local.yml is present, and make the user choose the behaviour explicitly.
…t flag wasn't used
sfc-gh-fcampbell
force-pushed
the
frank-migrate-local-flag
branch
from
9e0f227
to
8a51b56
Compare
sfc-gh-bdufour
approved these changes
Sep 27, 2024
sfc-gh-pjafari
approved these changes
Sep 27, 2024
sfc-gh-astus
approved these changes
Sep 30, 2024
sfc-gh-jsikorski
pushed a commit
that referenced
this pull request
Sep 30, 2024
…it (#1636) Fixes bug with `snow helpers v1-to-v2` if a `snowflake.local.yml` is present. Currently, the local file isn't renamed, so a v1 local can be overlaid onto a v2 main definition file after migration, which breaks subsequent commands. Since local overrides are no longer a desired feature in PDFv2, we don't convert them unless `--migrate-local-overrides` is used.
Merged
8 tasks
sfc-gh-jsikorski
pushed a commit
that referenced
this pull request
Sep 30, 2024
…it (#1636) Fixes bug with `snow helpers v1-to-v2` if a `snowflake.local.yml` is present. Currently, the local file isn't renamed, so a v1 local can be overlaid onto a v2 main definition file after migration, which breaks subsequent commands. Since local overrides are no longer a desired feature in PDFv2, we don't convert them unless `--migrate-local-overrides` is used.
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
…it (#1636) Fixes bug with `snow helpers v1-to-v2` if a `snowflake.local.yml` is present. Currently, the local file isn't renamed, so a v1 local can be overlaid onto a v2 main definition file after migration, which breaks subsequent commands. Since local overrides are no longer a desired feature in PDFv2, we don't convert them unless `--migrate-local-overrides` is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Fixes bug with
snow helpers v1-to-v2if asnowflake.local.ymlis present. Currently, the local file isn't renamed, so a v1 local can be overlaid onto a v2 main definition file after migration, which breaks subsequent commands. Since local overrides are no longer a desired feature in PDFv2, we don't convert them unless--migrate-local-overridesis used.