Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1706990 Extract fields in compat module #1663

Merged
merged 3 commits into from
Oct 3, 2024
Merged

SNOW-1706990 Extract fields in compat module #1663

merged 3 commits into from
Oct 3, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

@sfc-gh-fcampbell sfc-gh-fcampbell commented Oct 3, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

No material changes, just extracting the entity finding logic into _find_app_and_package_entities and the Typer options into APP_AND_PACKAGE_OPTIONS slim the diff in #1635.

@sfc-gh-fcampbell sfc-gh-fcampbell changed the title SNOW-1706990 Extract _find_app_and_package_entities function SNOW-1706990 Extract fields in compat module Oct 3, 2024
@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review October 3, 2024 13:56
@sfc-gh-fcampbell sfc-gh-fcampbell requested a review from a team as a code owner October 3, 2024 13:56
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 3, 2024 14:18
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 3, 2024 16:54
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 8ab0a0f into main Oct 3, 2024
19 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-find-entities branch October 3, 2024 17:12
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-fcampbell
SNOW-1706990 Extract fields in compat module (#1663)
42fb8bc 
No material changes, just extracting the entity finding logic into `_find_app_and_package_entities` and the Typer options into `APP_AND_PACKAGE_OPTIONS` slim the diff in #1635.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-bdufour