Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1706990 Convert snow app events to v2-native #1698

Merged
merged 1 commit into from
Oct 10, 2024
Merged

SNOW-1706990 Convert snow app events to v2-native #1698

merged 1 commit into from
Oct 10, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Converts snow app validate to operate on v2 entities natively. Moved some code from the command to the entity but behaviour hasn't changed.

@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-events-v2 branch 2 times, most recently from 768b2fa to e6f085e Compare October 9, 2024 20:43
Base automatically changed from frank-snow-app-validate-v2 to main October 9, 2024 21:22
@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review October 9, 2024 21:22
@sfc-gh-fcampbell sfc-gh-fcampbell requested review from a team as code owners October 9, 2024 21:22
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 10, 2024 12:30
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 6421ff2 into main Oct 10, 2024
21 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-snow-app-events-v2 branch October 10, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-bdufour