Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error message in artifact logic #1700

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fixed error message in artifact logic #1700

merged 1 commit into from
Oct 10, 2024

Conversation

sfc-gh-bdufour
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Fixed a bug identified by @sfc-gh-astus where the wrong message can be issued when a snowflake.yml file contains conflicting artifact rules.

@sfc-gh-bdufour sfc-gh-bdufour requested a review from a team as a code owner October 10, 2024 12:13
@sfc-gh-bdufour sfc-gh-bdufour merged commit 1d45ee3 into main Oct 10, 2024
19 checks passed
@sfc-gh-bdufour sfc-gh-bdufour deleted the bdufour-fix-artifact-error branch October 10, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mchok sfc-gh-mchok sfc-gh-mchok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-bdufour @sfc-gh-mchok