Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1706990 Convert snow app version commands to v2-native #1708

Merged
merged 2 commits into from
Oct 11, 2024
Merged

SNOW-1706990 Convert snow app version commands to v2-native #1708

merged 2 commits into from
Oct 11, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Converts snow app version commands to operate on v2 entities by default. Also removes @nativeapp_definition_v2_to_v1 decorator and test_v2_to_v1.py since they're now unused.

@sfc-gh-fcampbell sfc-gh-fcampbell changed the title SNOW-1706990 Convert snow app version commands to v2-native SNOW-1706990 Convert snow app version commands to v2-native Oct 11, 2024
@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review October 11, 2024 16:09
@sfc-gh-fcampbell sfc-gh-fcampbell requested review from a team as code owners October 11, 2024 16:09
sfc-gh-bdufour
sfc-gh-bdufour previously approved these changes Oct 11, 2024
View reviewed changes
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 11, 2024 16:14
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 9232ed6 into main Oct 11, 2024
19 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-snow-app-version-v2 branch October 11, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-bdufour