SNOW-1706990 Update/remove tests that use NativeAppRunProcessor #1726
Conversation
| return drop_application_before_upgrade(cascade=True) | ||
| else: | ||
| generic_sql_error_handler(err) | ||
| self.drop_application_before_upgrade( |
There was a problem hiding this comment.
just moved this to a static so it can be called externally (for now)
sfc-gh-fcampbell
force-pushed
the
frank-move-run-processor-tests
branch
2 times, most recently
from
b21654b
to
fabe3f9
Compare
sfc-gh-fcampbell
force-pushed
the
frank-move-run-processor-tests
branch
from
fabe3f9
to
26ba704
Compare
tests/nativeapp/factories.py
Outdated
| Usage: | ||
| Create a pdf dict with definition_version: "1", native_app with faker-generated name and an empty artifacts list and |
There was a problem hiding this comment.
Is it still true that we create "1" PDF here? This whole usage seems a bit outdated TBH, since PdfFactory shouldn't really be used directly most (all?) of the time. Should we move the whole usage thing to a file comment at the very top and use it to document the overall usage of the factories defined here? We can use something like V2 as a running example, since that's intended to be the default.
There was a problem hiding this comment.
ah yeah, i can move this to PdfV10Factory. Can i do the overall comment update separately?
There was a problem hiding this comment.
the PDF factories are meant to be used externally, in the case where you want a project definition and snowflake.yml file, but you don't need other files on-disk
sfc-gh-fcampbell
force-pushed
the
frank-move-run-processor-tests
branch
from
70a8f73
to
8ddf8e5
Compare
sfc-gh-fcampbell
force-pushed
the
frank-move-run-processor-tests
branch
from
8ddf8e5
to
e90237d
Compare
Pre-review checklist
Changes description
Update/remove tests that use NativeAppRunProcessor. Removed
tests/nativeapp/test_package_scripts.pybecause package scripts are now converted to post-deploy hooks for all commands, the package script code isn't used anymore.