Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split special cases of test_nativeapp_post_deploy into separate v2-only #1728

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Split special cases of test_nativeapp_post_deploy into separate v2-only #1728

merged 1 commit into from
Oct 16, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

@sfc-gh-fcampbell sfc-gh-fcampbell commented Oct 16, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

test_nativeapp_post_deploy has extra parametrizations that don't need to run for every type of project, so let's leave the full definition version parametrization to a simple test and have dedicated tests for the other logic.

Reduces integration suite runtime to ~13 minutes.

@sfc-gh-fcampbell sfc-gh-fcampbell changed the title Split special cases of test_nativeapp_post_deploy into separate v2-on… Split special cases of test_nativeapp_post_deploy into separate v2-only Oct 16, 2024
@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review October 16, 2024 15:07
@sfc-gh-fcampbell sfc-gh-fcampbell requested a review from a team as a code owner October 16, 2024 15:07
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 16, 2024 15:19
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 7e330f5 into main Oct 16, 2024
19 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-reduce-post-deploy-test-parametrization branch October 16, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-bdufour