Add more parameters for connection add #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-turbaszek
requested review from
sfc-gh-pjob,
sfc-gh-jsikorski and
sfc-gh-astus
as code owners
src/snowcli/cli/connection.py
Outdated
| } | ||
| print(connection_entry) |
| prompt="Snowflake account", | ||
| help="Name assigned to your Snowflake account.", | ||
| help="Account name to be used to authenticate with Snowflake.", | ||
| show_default=False, |
There was a problem hiding this comment.
What happened with account? Why removed prompt?
There was a problem hiding this comment.
Good catch, fixed
| click_type=OptionalPrompt(), | ||
| prompt="Snowflake region", | ||
| help="Region name if not the default Snowflake Database deployment.", | ||
| ), |
There was a problem hiding this comment.
First time see region, do we need this one?
What about role, warehouse and protocol?
There was a problem hiding this comment.
Yup, region is supported by snowflake python connector. Good point about role and wh which are more important. Added!
There was a problem hiding this comment.
My eyes bleeding looking at parameters and connection_entry order but iiyo
sfc-gh-astus
approved these changes
Jun 30, 2023
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Add more parameters for connection add * fixup! Add more parameters for connection add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Add more parameters to
snow connection addto support all basic options for connection configuration.