Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show --help as suggestion rather than -h #251

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Show --help as suggestion rather than -h #251

merged 1 commit into from
Jul 21, 2023

Conversation

sfc-gh-zblackwood
Copy link
Collaborator

@sfc-gh-zblackwood sfc-gh-zblackwood commented Jul 20, 2023 •
edited
Loading

This helps because -h is sometimes overridden (e.g. snow snowpark function create -h uses -h for handler). It's still usable in some cases (though perhaps should be removed altogether), but this means that if you have an incomplete command, it will say

Try 'snow <commands> --help' for help.

Rather than this (which doesn't always work)

Try 'snow <commands> --h' for help.

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added new automated tests to verify correctness of my new code.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the section below.

Changes description

...

@sfc-gh-zblackwood
Show --help as suggestion rather than -h
3595461 
This helps because -h is sometimes overridden (e.g. `snow snowpark function create -h` uses -h for handler). It's still usable in some cases (though perhaps should be removed altogether), but this means that if you have an incomplete command, it will say 
```
Try 'snow <commands> --help' for help.
```
@sfc-gh-pjob sfc-gh-pjob merged commit cfa3aa2 into snowflakedb:main Jul 21, 2023
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-zblackwood
Show --help as suggestion rather than -h (#251)
f1f6036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pjob sfc-gh-pjob sfc-gh-pjob approved these changes

@sfc-gh-turbaszek sfc-gh-turbaszek Awaiting requested review from sfc-gh-turbaszek

@sfc-gh-jsikorski sfc-gh-jsikorski Awaiting requested review from sfc-gh-jsikorski

@sfc-gh-astus sfc-gh-astus Awaiting requested review from sfc-gh-astus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-zblackwood @sfc-gh-pjob