Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_connection option #261

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

sfc-gh-turbaszek
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added new automated tests to verify correctness of my new code.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the section below.

Changes description

...

sfc-gh-astus
sfc-gh-astus previously approved these changes Jul 25, 2023
@@ -48,6 +53,13 @@ def default(
callback=_version_callback,
is_eager=True,
),
info: bool = typer.Option(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's doing this info? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@sfc-gh-turbaszek sfc-gh-turbaszek merged commit ae994e3 into main Jul 25, 2023
14 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the add-default-connection-option branch July 25, 2023 08:55
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants