Refactor procedure commands #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-turbaszek
requested review from
sfc-gh-pjob,
sfc-gh-jsikorski and
sfc-gh-astus
as code owners
| @@ -84,6 +85,6 @@ def create( | |||
| runtime_version=3.8 | |||
| imports=('@{artifact_file}') | |||
| handler='{handler}' | |||
| packages=() | |||
| packages=({packages_list}) | |||
There was a problem hiding this comment.
Could you explain why you removed this?
sfc-gh-astus
approved these changes
Aug 10, 2023
sfc-gh-astus
previously approved these changes
Aug 18, 2023
sfc-gh-turbaszek
force-pushed
the
refactor-procedure-commands-2
branch
from
52bdb34
to
36e2935
Compare
sfc-gh-astus
approved these changes
Aug 21, 2023
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Refactor procedure commands * Do not fail on unused snapshots * fixup! Do not fail on unused snapshots * fixup! fixup! Do not fail on unused snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
...