Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control+C to cancel a query support #1

Closed
smtakeda opened this issue Aug 7, 2017 · 2 comments
Closed

Control+C to cancel a query support #1

smtakeda opened this issue Aug 7, 2017 · 2 comments

Comments

@smtakeda
Copy link
Contributor

smtakeda commented Aug 7, 2017

Before forgetting this (like me for golang), I'm filing an issue here for reminder.
@howryu
Copy link
Contributor

howryu commented Mar 8, 2018

Ctrl-C signal should be tracked by application, not by .net driver itself. In #22, async query execution is supported, which can take a cancellation token as argument. Application should catch ctrl-c signal and fire cancellation token source to cancel the query.

@howryu howryu closed this as completed Mar 8, 2018
@smtakeda
Copy link
Contributor Author

smtakeda commented Mar 8, 2018

Ok. having async support, what code change will be required for the existing test example?
https://github.com/snowflakedb/snowflake-connector-net/blob/master/Snowflake.Data.Tests/SFDbCommandIT.cs#L152

ChTimTsubasa pushed a commit that referenced this issue Aug 6, 2019
@stegus64
Merge pull request #1 from stegus64/pr-154
c95f529 
Fix for #154. Removed incorrect call to ToUniversalTime()
ChTimTsubasa pushed a commit that referenced this issue Aug 6, 2019
@stegus64
Revert "Merge pull request #1 from stegus64/pr-154"
13ed006 
This reverts commit c95f529, reversing
changes made to 0b2f1d6.
@RobertChrist RobertChrist mentioned this issue Jan 4, 2023
Closed
sfc-gh-mhofman added a commit that referenced this issue Oct 16, 2023
@sfc-gh-mhofman
pool/SNOW-902611 #1/4 removed singleton pattern from SessionPool; int…
7ff70e4 
…roduced ne… (#791)

### Description
Connection Pool v1
-Removal of singleton pattern from SessionPool
-Introduction of interface and its implementation of ConnectionManager
-Split integration tests of ConnectionPool (into separate files) + some
cleanup in the classes

### Checklist
- [x] Code compiles correctly
- [x] Code is formatted according to [Coding
Conventions](../CodingConventions.md)
- [x] Created tests which fail without the change (if possible)
- [x] All tests passing (`dotnet test`)
- [x] Extended the README / documentation, if necessary
- [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
@jtrumpower jtrumpower mentioned this issue Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smtakeda @howryu