Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close() does not update ConnectionState #72

Closed
akrock opened this issue Oct 3, 2018 · 2 comments
Closed

Close() does not update ConnectionState #72

akrock opened this issue Oct 3, 2018 · 2 comments
Assignees
@ChTimTsubasa
Milestone
v1.0.5

Comments

@akrock
Copy link
Contributor

akrock commented Oct 3, 2018 •
edited
Loading

Issue description

Calling Close() on the connection does not actually update the connection state.

Expected: State to be ConnectionState.Closed after calling Close(). Currently ConnectionState.Open.
@akrock akrock changed the title Close() does not update Conn Close() does not update ConnectionState Oct 3, 2018
akrock added a commit to akrock/snowflake-connector-net that referenced this issue Oct 3, 2018
@akrock
Fix for snowflakedb#72
79e8e69 
Set  _connectionState = ConnectionState.Closed on Close()
@akrock akrock mentioned this issue Oct 3, 2018
Closed
@howryu
Copy link
Contributor

howryu commented Oct 12, 2018

@ChTimTsubasa Should be simple. Just add a test and merge.

akrock added a commit to akrock/snowflake-connector-net that referenced this issue Oct 18, 2018
@akrock
Merge pull request #7 from akrock/72-SetConnectionStateOnClose
545b1b0 
Fix for snowflakedb#72
howryu pushed a commit that referenced this issue Oct 29, 2018
@akrock @howryu
Fix for #72
a5bf573 
Set  _connectionState = ConnectionState.Closed on Close()
@howryu
Copy link
Contributor

howryu commented Oct 29, 2018

Merged in #88

@howryu howryu closed this as completed Oct 29, 2018
@howryu howryu added this to the v1.0.5 milestone Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChTimTsubasa ChTimTsubasa

Labels
None yet
Projects
None yet
Milestone
v1.0.5
Development

No branches or pull requests
3 participants
@akrock @howryu @ChTimTsubasa