Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NotImplementedExceptions from SnowflakeDbParameter properties.` #55

Merged
merged 3 commits into from
Aug 31, 2018
+21 −20
Merged

Remove NotImplementedExceptions from SnowflakeDbParameter properties.` #55

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
107bbc0
Relax getters and setters in SnowflakeDbParameter.cs so that
Jul 26, 2018
d52cfdb
disable a resharper warning
Aug 20, 2018
aa23c01
Merge remote-tracking branch 'upstream/master'
Aug 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions Snowflake.Data/Client/SnowflakeDbParameter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ public override ParameterDirection Direction

public override bool IsNullable
{
get
{
throw new NotImplementedException();
}
get { return false; }

set
{
throw new NotImplementedException();
if (value != false)
{
throw new SnowflakeDbException(SFError.UNSUPPORTED_FEATURE);
}
}
}

Expand All @@ -73,40 +73,41 @@ public override string ParameterName

public override int Size
{
get
{
throw new NotImplementedException();
}
get { return 0; }

set
{
throw new NotImplementedException();
if (value != 0)
{
throw new SnowflakeDbException(SFError.UNSUPPORTED_FEATURE);
}
}
}

public override string SourceColumn
{
get
{
throw new NotImplementedException();
}
get { return null; }

set
{
throw new NotImplementedException();
if (value != null)
{
throw new SnowflakeDbException(SFError.UNSUPPORTED_FEATURE);
}
}
}

public override bool SourceColumnNullMapping
{
get
{
throw new NotImplementedException();
}
get { return false; }

set
{
throw new NotImplementedException();
// ReSharper disable once RedundantBoolCompare (compare to false for clarity)
if (value != false)
{
throw new SnowflakeDbException(SFError.UNSUPPORTED_FEATURE);
}
}
}

Expand Down