PR - Fix for #69 #70
PR - Fix for #69 #70
Conversation
Handle the OverflowExcpetion and return -1.
|
This PR addresses #69 |
|
@akrock Do you have a copy of the HTTP/JSON response that came back? If it's just a large number then the response parsing can (and should) be updated to parse that number as a |
|
Yeah you could also just request However you will still need to figure out what should be returned by the method in the case that it exceeds int.MaxValue since you are forced by the interface to return an int for |
|
Seems that should be the way. This actually happens after update/delete/insert succeed in the server side. Exception is not a good idea, which will lead to user thinking that their insertion failed. But I was wondering if there is a better to inform user. Like in JDBC, there is a class call SqlWarning. https://docs.oracle.com/javase/7/docs/api/java/sql/SQLWarning.html I did not find anything similar in .net |
|
Rewrote this PR to use GetValue instead of handling the overflow exceptions from GetValue, still returns -1 in the case that more than int.MaxValue rows were modified. |
|
Hi, we collided into this problem last night, please accept this PR or find alternative solution, pretty please. |
|
Hi, any comment on this @howryu? |
|
@ikudjoi ThanksGiving now. I will fix it next Monday since I don't have access to my dev machine now. Sorry for that. |
|
Fair enough! :) |
|
Ping |
|
Working on it now. |
|
Merged in #95 |
I searched but I was not able to figure out the recommended driver behavior for this case.
I opted to return -1 if more than int.MaxValue rows were mutated and an OverflowException was generated. This may be non-standard behavior and you should probably confirm what the expected behavior for a .NET driver is in this case.