Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 84 #89

Merged
merged 3 commits into from
Oct 30, 2018
Merged

Pr 84 #89

merged 3 commits into from
Oct 30, 2018

Conversation

howryu
Copy link
Contributor

@howryu howryu commented Oct 30, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 30, 2018

Codecov Report

Merging #89 into master will decrease coverage by 1.73%.
The diff coverage is 36.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   78.45%   76.72%   -1.74%     
==========================================
  Files          27       29       +2     
  Lines        1866     1933      +67     
  Branches      147      156       +9     
==========================================
+ Hits         1464     1483      +19     
- Misses        350      394      +44     
- Partials       52       56       +4
Impacted Files Coverage Δ
Snowflake.Data/Client/SnowflakeDbCommandBuilder.cs 0% <0%> (ø)
Snowflake.Data/Client/SnowflakeDbTransaction.cs 83.78% <100%> (-8.11%) ⬇️
Snowflake.Data/Core/SFSessionProperty.cs 100% <100%> (ø) ⬆️
Snowflake.Data/Client/SnowflakeDbFactory.cs 42.85% <42.85%> (ø)
Snowflake.Data/Client/SnowflakeDbConnection.cs 88% <54.54%> (-3.67%) ⬇️
Snowflake.Data/Client/SnowflakeDbCommand.cs 79.37% <60.86%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2bb8cb...2ea7582. Read the comment docs.

@howryu howryu merged commit 66d4239 into master Oct 30, 2018
@howryu howryu deleted the pr-84 branch October 30, 2018 16:42
@howryu howryu added this to the v1.0.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants