[Connection pool] skip heartbeat check in keep-alive mode #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In connection pool, skip heartbeat check when keep-alive is enabled.
Description
acquire()
call on the connection pool runs a heartbeat query (given thattestOnBorrow
of the pool is kept astrue
)clientSessionKeepAlive
is true, skip the heartbeat query check and check only the client-side connection status.clientSessionKeepAlive
and its related configs (clientSessionKeepAliveHeartbeatFrequency
,SESSION_IDLE_TIMEOUT_MINS
) to make the connection pooling more efficient.Other changes
heartbeatAsync
intocheckHeartbeat
:false
instead of raising an Error.heartbeat
to reduce code duplication and ensure the consistency of "heartbeat" queries.