Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-748680: Update node fips docker image and re-add fips test #500

Merged
merged 34 commits into from
Sep 21, 2023

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf commented May 23, 2023

Update the node version on the docker image to fix the following error:
ERROR: npm v9.6.5 is known not to run on Node.js v12.0.0. This version of npm supports the following node versions: ^14.17.0 || ^16.13.0 || >=18.0.0. You can find the latest version at [https://nodejs.org/.](https://nodejs.org/)

Re-add fips test for centos7

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review May 23, 2023 19:48
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner May 23, 2023 19:48
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf changed the title Set centos7 node version to 14.17 Set centos7 node version to 14.17 and re-add fips test May 23, 2023
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-lf
Copy link
Collaborator Author

The "nodejs-centos7-fips" build is failing due to a syntax error: https://github.com/snowflakedb/snowflake-connector-nodejs/actions/runs/5073384764/jobs/9133365714?pr=500#step:6:272

For await loops are available from node 10.3 and above: https://node.green/#ES2018-features-Asynchronous-Iterators-for-await-of-loops. The 14.17.0 version is already specified in the docker file but looks like it wasn't picked up

The node version of the "nodejs-centos7-fips" image needs to be updated similar to how the "nodejs-centos7-node12" image was updated for the test to pass

@sfc-gh-igarish
Copy link
Collaborator

@sfc-gh-kdama ^^^^

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf changed the title Set centos7 node version to 14.17 and re-add fips test Update node fips docker image and re-add fips test Jun 23, 2023
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #500 (7c3b729) into master (63ea42a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files          56       56           
  Lines        5199     5199           
=======================================
  Hits         4409     4409           
  Misses        790      790           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf changed the title Update node fips docker image and re-add fips test SNOW-748680: Update node fips docker image and re-add fips test Sep 21, 2023
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit 319adc8 into master Sep 21, 2023
30 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the centos7node branch September 21, 2023 20:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants