Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-502598: Add async query execution #672
SNOW-502598: Add async query execution #672
Changes from all commits
f0abbf9
903a8d8
922acf6
a2e92cb
1ee54ed
b79a595
0a7b7c8
8d8bd87
a479942
a5b0fd3
038f781
72751cb
5ecda9b
e2240a0
3624ae7
924052c
6c00000
357359a
46748bb
6944e99
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 497 in lib/connection/connection.js
Codecov / codecov/patch
lib/connection/connection.js#L495-L497
Check warning on line 501 in lib/connection/connection.js
Codecov / codecov/patch
lib/connection/connection.js#L499-L501
Check warning on line 504 in lib/connection/connection.js
Codecov / codecov/patch
lib/connection/connection.js#L504
Check warning on line 539 in lib/connection/connection.js
Codecov / codecov/patch
lib/connection/connection.js#L539
Check warning on line 542 in lib/connection/connection.js
Codecov / codecov/patch
lib/connection/connection.js#L541-L542
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sfc-gh-ext-simba-lf - we have been refactoring and some questions arose from this part of code.
Specifically - did You ever noticed such case, that response['data'] is string, but 'content-type' headers are set to 'application/json' at the same time?
We expected axios to parse such data automatically (ad. e.g. https://masteringjs.io/tutorials/axios/json).
Could You provide some reproduction for such scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the tests added with the PR can help repro that scenario. Or a simpler repro would be something like:
The
getQueryStatus
function receives a response in string that is parsed into JSON