Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-950429: Set ESLint no-console rule to error #676

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Set the ESLint no-console rule to error to force the developer to use logger instead of console logging.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner October 26, 2023 11:55
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #676 (3be12ac) into master (cf17fa0) will decrease coverage by 0.07%.
The diff coverage is 60.00%.

❗ Current head 3be12ac differs from pull request most recent head a59dc40. Consider uploading reports for the commit a59dc40 to get more accurate results

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   87.78%   87.71%   -0.07%     
==========================================
  Files          60       60              
  Lines        5622     5591      -31     
==========================================
- Hits         4935     4904      -31     
  Misses        687      687              
Files Coverage Δ
lib/connection/connection_config.js 96.51% <100.00%> (-0.06%) ⬇️
lib/agent/https_proxy_ocsp_agent.js 10.81% <0.00%> (ø)
lib/core.js 96.87% <50.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit f49e3ef into master Oct 31, 2023
42 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-950429 branch October 31, 2023 09:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants